gnu: lsof: Update to 4.99.6.

* gnu/packages/lsof.scm (lsof): Update to 4.99.6.
[source]: Remove patch.
[arguments]: Remove field.
* gnu/packages/patches/lsof-compat-linux-6.9.patch: Remove file.
* gnu/local.mk (dist_patch_DATA): Remove it.

Change-Id: I451ae8fdc2e45b0c835a0ddc80ec851cd6fc2737
Signed-off-by: Efraim Flashner <efraim@flashner.co.il>

3 files changed, 2 insertions, 92 deletions

diff --git a/gnu/local.mk b/gnu/local.mk
index fabc3b68c93..22f86c64fc2 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1856,7 +1856,6 @@ dist_patch_DATA =						\
   %D%/packages/patches/lirc-reproducible-build.patch		\
   %D%/packages/patches/llvm-13-gcc-14.patch			\
   %D%/packages/patches/lm-sensors-hwmon-attrs.patch		\
-  %D%/packages/patches/lsof-compat-linux-6.9.patch		\
   %D%/packages/patches/lsof-fatal-test-failures.patch		\
   %D%/packages/patches/lua-CVE-2014-5461.patch                      \
   %D%/packages/patches/lua-pkgconfig.patch                      \
diff --git a/gnu/packages/lsof.scm b/gnu/packages/lsof.scm
index c22d352cf9d..07dd5590d25 100644
--- a/gnu/packages/lsof.scm
+++ b/gnu/packages/lsof.scm
@@ -37,7 +37,7 @@
 (define-public lsof
   (package
     (name "lsof")
-    (version "4.99.3")
+    (version "4.99.6")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -46,8 +46,7 @@
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1v32407al4j0hhcph95lv4xvr9h012lii29iyq41iwj39zwfavax"))
-              (patches (search-patches "lsof-compat-linux-6.9.patch"))))
+                "08p0c0wci9vam6b29ym7z7sip8gd0j0dz7zy4f0b32dw51rb3z9k"))))
     (build-system gnu-build-system)
     (native-inputs (list automake
                          autoconf
@@ -57,27 +56,6 @@
                          pkg-config
                          procps ;for ps
                          util-linux)) ;for unshare
-    (arguments
-     (list #:phases
-           #~(modify-phases %standard-phases
-               (add-after 'unpack 'fix-configure-ac-version
-                 ;; see https://github.com/lsof-org/lsof/commit/932a0b3b1992497e23fd9b8d31116b9ca9b0f98d
-                 ;; to fix tests/case-01-version.bash test fail.
-                 (lambda _
-                   (substitute* "configure.ac"
-                     (("4\\.99\\.0")
-                      "4.99.3"))))
-               (add-before 'bootstrap 'disable-failing-tests
-                 (lambda _
-                   (substitute* "Makefile.am"
-                     ;; Fails with ‘ERROR!!! client gethostbyaddr() failure’.
-                     (("(TESTS \\+=.*) tests/LTsock" _ prefix)
-                      prefix)
-                     ;; Fails on CoW filesystems (eg. btrfs)
-                     (("tests/LTlock") "")
-                     ;; Fails because /proc not mounted in sandbox
-                     (("\tdialects/linux/tests/case-20-epoll.bash \\\\")
-                      "\\")))))))
     (synopsis "Display information about open files")
     (description
      "Lsof stands for LiSt Open Files, and it does just that.
diff --git a/gnu/packages/patches/lsof-compat-linux-6.9.patch b/gnu/packages/patches/lsof-compat-linux-6.9.patch
deleted file mode 100644
index a7c09c7ecf0..00000000000
--- a/gnu/packages/patches/lsof-compat-linux-6.9.patch
+++ /dev/null
@@ -1,67 +0,0 @@
-This commit adds the patch that fixes:
-<https://github.com/lsof-org/lsof/issues/317>
-
-The issue was triggering the following error in the `test` phase that
-resulted in a build failure in Linux 6.9 or higher:
-
-    FAIL: lib/dialects/linux/tests/case-20-pidfd-pid.bash
-
-
-From c1678e3f6e4b4d984cb3078b7bf0c9e24bedb8ca Mon Sep 17 00:00:00 2001
-From: Jiajie Chen <c@jia.je>
-Date: Fri, 17 May 2024 15:22:35 +0800
-Subject: [PATCH] [linux] Maintain original output for pidfd in linux 6.9
-
----
- 00DIST                     |  3 +++
- lib/dialects/linux/dproc.c | 13 +++++++++++++
- 2 files changed, 16 insertions(+)
-
-diff --git a/00DIST b/00DIST
-index d5a0349..9a29611 100644
---- a/00DIST
-+++ b/00DIST
-@@ -5605,6 +5605,9 @@ Supplement	Regenerated the 4.04 distribution to correct a non-
- 
- 		[linux] Do not embed kernel version in CFLAGS (#314)
- 
-+		[linux] Linux 6.9 changed the pidfs appearence in procfs. Try
-+		to maintain original output in lsof (#317)
-+
- 
- Vic Abell <abe@purdue.edu>
- July 14, 2018
-diff --git a/lib/dialects/linux/dproc.c b/lib/dialects/linux/dproc.c
-index cb6bb64..3a7a120 100644
---- a/lib/dialects/linux/dproc.c
-+++ b/lib/dialects/linux/dproc.c
-@@ -1273,6 +1273,10 @@ static int process_id(struct lsof_context *ctx, /* context */
- #endif     /* defined(HASEPTOPTS) */
-                 if (rest && rest[0] == '[' && rest[1] == 'p')
-                     fdinfo_mask |= FDINFO_PID;
-+                else if (Lf->ntype == N_REGLR && rest && *rest && strcmp(pbuf, "pidfd") == 0) {
-+                    // https://github.com/lsof-org/lsof/issues/317
-+                    fdinfo_mask |= FDINFO_PID;
-+                }
- 
-                 if ((av = get_fdinfo(ctx, pathi, fdinfo_mask, &fi)) &
-                     FDINFO_POS) {
-@@ -1338,6 +1342,15 @@ static int process_id(struct lsof_context *ctx, /* context */
-                     Lf->sf |= SELPTYINFO;
-                 }
- #endif /* defined(HASEPTOPTS) && defined(HASPTYEPT) */
-+                else if (Lf->ntype == N_REGLR && rest && *rest && Lf->nm &&
-+                         strcmp(Lf->nm, "pidfd") == 0) {
-+                    // https://github.com/lsof-org/lsof/issues/317
-+                    // pidfd since Linux 6.9 becomes a regular file:
-+                    // /proc/PID/fd/FD -> pidfd:[INODE]
-+                    (void)snpf(rest, sizeof(pbuf) - (rest - pbuf),
-+                                "[pidfd:%d]", fi.pid);
-+                    enter_nm(ctx, rest);
-+                }
- 
-                 if (Lf->sf)
-                     link_lfile(ctx);
--- 
-2.45.2
-