gnu: Remove #:test-target argument.

* gnu/packages/astronomy.scm (libsep),
* gnu/packages/bioinformatics.scm (megahit),
* gnu/packages/bittorrent.scm (qbittorrent),
* gnu/packages/calendar.scm (date),
* gnu/packages/check.scm (klee, trompeloeil),
* gnu/packages/compression.scm (zziplib),
* gnu/packages/cpp.scm (immer, lager, zug),
* gnu/packages/databases.scm (timescaledb),
* gnu/packages/emulators.scm (dolphin-emu),
* gnu/packages/fpga.scm (systemc),
* gnu/packages/game-development.scm (box2d),
* gnu/packages/games.scm (megaglest, openclonk, teeworld),
* gnu/packages/glib.scm (sdbus-c++),
* gnu/packages/gnucash.scm (gnucash),
* gnu/packages/graph.scm (igraph),
* gnu/packages/image.scm (exiv2),
* gnu/packages/inkscape.scm (inkscape),
* gnu/packages/instrumentation.scm (yactfr),
* gnu/packages/kde-multimedia.scm (elisa),
* gnu/packages/linux.scm (falcosecurity-libs),
* gnu/packages/llvm.scm (libcxx, libomp-15),
* gnu/packages/machine-learning.scm (ctranslate2, tvm),
* gnu/packages/maths.scm (blitz),
* gnu/packages/messaging.scm (libphonenumber),
* gnu/packages/music.scm (clementine, libdiscid, opustags, strawberry),
* gnu/packages/opencog.scm (atomspace, attention, cogserver, cogutil,
opencog),
* gnu/packages/python-xyz.scm (pybind11)
* gnu/packages/radio.scm (libfec, libcorrect),
* gnu/packages/serialization.scm (qtcsv),
* gnu/packages/shells.scm (fish),
* gnu/packages/tls.scm (aws-lc),
* gnu/packages/web.scm (wabt),
* gnu/packages/vulkan.com (spirv-llvm-translator)
[arguments]: Move #:test-target to ...
<#:phases>: ... 'check phase.

* gnu/packages/algebra.scm (xtensor),
* gnu/packages/astronomy (stellarium),
* gnu/packages/bioinformatics.scm (libsbml),
* gnu/packages/chemistry.scm (openbabel),
* gnu/packages/cpp.scm (xsimd, xtl),
* gnu/packages/documentation.scm (doxygen),
* gnu/packages/lua.scm (selene),
* gnu/packages/libftdi.scm (libftdi),
* gnu/packages/llvm.scm (cling, libomp@12, libomp@13),
* gnu/packages/hyperledger.scm (hyperledger-iroha),
* gnu/packages/markup.scm (cmark, cmark-gfm),
* gnu/packages/maths.scm (cryptominisat, double-conversion),
* gnu/packages/mp3.scm (chromaprint),
* gnu/packages/qt.scm (qtpromise)
* gnu/packages/rdf.scm (clucene),
* gnu/packages/sync.scm (lsyncd)
[arguments}: Remove #:test-target.

* gnu/packages/engineering.scm (libfive),
* gnu/packages/game-development.scm (box2d-3)
[arguments]: Remove #:test-target and disable tests.

Change-Id: I0a82091df1789980bbbac0c334b6f993c36f412a

1 files changed, 39 insertions, 31 deletions

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index a0967bc5a7b..5651a245feb 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -1617,38 +1617,46 @@ channels.")
         (base32 "1qm6bvj28l42km009nc60gffn1qhngc0m2wjlhf90si3mcc8d99m"))))
     (build-system cmake-build-system)
     (arguments
-     `(#:test-target "tests"
-       #:configure-flags (list "-DEXIV2_BUILD_UNIT_TESTS=ON"
-                               ;; darktable needs BMFF to support
-                               ;; CR3 files.
-                               "-DEXIV2_ENABLE_BMFF=ON")
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'patch-gcc-reference
-           (lambda _
-             ;; _GLIBCXX_ASSERTIONS brings reference to GCC.
-             (substitute* "cmake/compilerFlags.cmake"
-               (("add_compile_options[(]-Wp,-D_GLIBCXX_ASSERTIONS[)]")
-                ""))))
-         (add-after 'install 'delete-static-libraries
-           (lambda* (#:key outputs #:allow-other-keys)
-             (let* ((out (assoc-ref outputs "out"))
-                    (lib (string-append out "/lib")))
-               (for-each delete-file (find-files lib "\\.a$")))))
+     (list
+      #:configure-flags
+      #~(list "-DEXIV2_BUILD_UNIT_TESTS=ON"
+              ;; darktable needs BMFF to support
+              ;; CR3 files.
+              "-DEXIV2_ENABLE_BMFF=ON")
+      #:modules '((guix build cmake-build-system)
+                  ((guix build gnu-build-system) #:prefix gnu:)
+                  (guix build utils))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'patch-gcc-reference
+            (lambda _
+              ;; _GLIBCXX_ASSERTIONS brings reference to GCC.
+              (substitute* "cmake/compilerFlags.cmake"
+                (("add_compile_options[(]-Wp,-D_GLIBCXX_ASSERTIONS[)]")
+                 ""))))
+          (add-after 'install 'delete-static-libraries
+            (lambda* (#:key outputs #:allow-other-keys)
+              (let* ((out (assoc-ref outputs "out"))
+                     (lib (string-append out "/lib")))
+                (for-each delete-file (find-files lib "\\.a$")))))
+          (replace 'check
+            (lambda* (#:rest args)
+              (apply (assoc-ref gnu:%standard-phases 'check)
+                     #:test-target "tests" args)))
 
-         ,@(if (or (target-ppc64le?)
-                   (target-aarch64?)
-                   (target-riscv64?))
-               '((add-after 'unpack 'adjust-tests
-                   (lambda _
-                     ;; Adjust test on ppc64 and aarch64, where no exception
-                     ;; is raised and thus the return value is different.  See
-                     ;; <https://github.com/Exiv2/exiv2/issues/365> and
-                     ;; <https://github.com/Exiv2/exiv2/issues/933>.
-                     (substitute* "tests/bugfixes/github/test_CVE_2018_12265.py"
-                       (("\\$uncaught_exception \\$addition_overflow_message\n") "")
-                       (("retval = \\[1\\]") "retval = [0]")))))
-               '()))))
+          #$@(if (or (target-ppc64le?)
+                    (target-aarch64?)
+                    (target-riscv64?))
+                 '((add-after 'unpack 'adjust-tests
+                     (lambda _
+                       ;; Adjust test on ppc64 and aarch64, where no exception
+                       ;; is raised and thus the return value is different.  See
+                       ;; <https://github.com/Exiv2/exiv2/issues/365> and
+                       ;; <https://github.com/Exiv2/exiv2/issues/933>.
+                       (substitute* "tests/bugfixes/github/test_CVE_2018_12265.py"
+                         (("\\$uncaught_exception \\$addition_overflow_message\n") "")
+                         (("retval = \\[1\\]") "retval = [0]")))))
+                 '()))))
     (propagated-inputs
      (list expat zlib))
     (native-inputs